Skip to content

Commit

Permalink
add upper pin to jsonschema
Browse files Browse the repository at this point in the history
jsonschema 4.18 will introduce changes that are incompatible
with asdf. More details can be found in:
#1485
this commit adds an upper pin to jsoncschema and removes
it from the devdeps testing
an issue was created to track removal of the pin:
#1486
  • Loading branch information
braingram committed Mar 15, 2023
1 parent d33ca09 commit bbded5d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ The ASDF Standard is at v1.6.0
- Deprecate asdf.tests.helpers [#1440]
- respect umask when determining file permissions for written files [#1451]
- rename master branch to main [#1479]
- require jsonschema<4.18 [#1487]

2.14.3 (2022-12-15)
-------------------
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies = [
"importlib-metadata>=4.11.4",
'importlib_resources>=3; python_version < "3.9"',
"jmespath>=0.6.2",
"jsonschema>=4.0.1",
"jsonschema<4.18,>=4.0.1", # jsonschema 4.18 contains incompatible changes: https://github.com/asdf-format/asdf/issues/1485
"numpy>=1.20",
'numpy<1.25,>=1.20; python_version < "3.9"',
"packaging>=19",
Expand Down
3 changes: 2 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ git+https://github.com/asdf-format/asdf-wcs-schemas
git+https://github.com/astropy/astropy
git+https://github.com/spacetelescope/gwcs
git+https://github.com/yaml/pyyaml.git
git+https://github.com/python-jsonschema/jsonschema
# jsonschema 4.18 contains incompatible changes: https://github.com/asdf-format/asdf/issues/1485
#git+https://github.com/python-jsonschema/jsonschema

scipy>=0.0.dev0
numpy>=0.0.dev0 ; python_version > "3.8"

0 comments on commit bbded5d

Please sign in to comment.