Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address bug when using memory maps with open file handle in readonly mode #574

Closed
drdavella opened this issue Oct 24, 2018 · 3 comments · Fixed by #579
Closed

Address bug when using memory maps with open file handle in readonly mode #574

drdavella opened this issue Oct 24, 2018 · 3 comments · Fixed by #579

Comments

@drdavella
Copy link
Contributor

This was raised in a discussion with @vmarkovtsev in #573. There should be a test case and better error handling, as well as better documentation.
@drdavella
Copy link
Contributor Author

drdavella commented Oct 24, 2018 •
edited
Loading

See d808f93#r227866944 for related discussion and a useful test case.

@drdavella drdavella mentioned this issue Oct 24, 2018
Merged
vmarkovtsev added a commit to vmarkovtsev/asdf that referenced this issue Oct 24, 2018
@vmarkovtsev
Remove the note about file mode for copy_arrays
62561d3 
See asdf-format#574
@vmarkovtsev
Copy link
Contributor

This is relevant: https://github.com/spacetelescope/asdf/blob/master/asdf/tests/helpers.py#L204

@drdavella
Copy link
Contributor Author

Good catch, thanks.

drdavella added a commit to drdavella/asdf that referenced this issue Oct 24, 2018
@drdavella
Attempt to reproduce error reported in asdf-format#574
8213901
@drdavella drdavella mentioned this issue Oct 24, 2018
Closed
vmarkovtsev added a commit to vmarkovtsev/asdf that referenced this issue Oct 25, 2018
@vmarkovtsev
Reproduce SIGSEGV (asdf-format#574)
8ab6f09
@drdavella drdavella mentioned this issue Oct 26, 2018
Merged
3 tasks
drdavella pushed a commit that referenced this issue Nov 14, 2018
@vmarkovtsev @drdavella
Remove the note about file mode for copy_arrays
4c717df 
See #574
@asdf-format asdf-format deleted a comment from stscijgbot Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor, better mode handling, deprecate asdf.AsdfFile.open drdavella/asdf
2 participants
@drdavella @vmarkovtsev