Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema URI resolving when the URI prefix is also claimed by a legacy extension #1029

Conversation

eslavich
Copy link
Contributor

This fixes a bug where the schema loader looks for content on disk when it should be retrieving it from the ResourceManager instance.

Resolves #1028

@eslavich eslavich added this to the 2.8.2 milestone Nov 30, 2021
@eslavich eslavich added the bug label Dec 1, 2021
@eslavich
Copy link
Contributor Author

eslavich commented Dec 1, 2021

This passes the jwst regression tests (one unrelated failure):

https://plwishmaster.stsci.edu:8081/job/RT/job/eslavich-dev/143/

Copy link
Contributor

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perrygreenfield perrygreenfield merged commit 61c9d90 into asdf-format:master Dec 2, 2021
@eslavich eslavich deleted the eslavich-fix-resolving-with-stsci-uri branch December 2, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URIs in custom schemas do not resolve correctly
2 participants