Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python3 as executable instead of python in tests #1033

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Use python3 as executable instead of python in tests #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
2.9.0 (unreleased)
------------------

- Fix more use of 'python' where 'python3' is intended. [#1033]

2.8.2 (2021-12-06)
------------------

Expand Down
8 changes: 4 additions & 4 deletions compatibility_tests/test_file_compatibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def get_supported_versions(env_path):
installed in the specified virtual environment.
"""
script = r"""import asdf; print("\n".join(str(v) for v in asdf.versioning.supported_versions))"""
output = env_check_output(env_path, "python", "-c", script)
output = env_check_output(env_path, "python3", "-c", script)
return [asdf.versioning.AsdfVersion(v) for v in output.split("\n")]


Expand All @@ -110,7 +110,7 @@ def get_installed_version(env_path):
virtual environment.
"""
script = r"""import asdf; print(asdf.__version__)"""
return StrictVersion(env_check_output(env_path, "python", "-c", script))
return StrictVersion(env_check_output(env_path, "python3", "-c", script))


@pytest.fixture(scope="module", params=PATCH_VERSIONS)
Expand Down Expand Up @@ -176,7 +176,7 @@ def test_file_compatibility(asdf_version, env_path, tmpdir):
if asdf_version >= MIN_VERSION_NEW_FILES:
current_file_path = Path(str(tmpdir))/"test-current.asdf"
generate_file(current_file_path, standard_version)
assert env_run(env_path, "python", ASSERT_SCRIPT_PATH, current_file_path, capture_output=True), (
assert env_run(env_path, "python3", ASSERT_SCRIPT_PATH, current_file_path, capture_output=True), (
"asdf library version {} failed to read an ASDF Standard {} ".format(asdf_version, standard_version) +
"file produced by this code"
)
Expand All @@ -185,7 +185,7 @@ def test_file_compatibility(asdf_version, env_path, tmpdir):
# can be read by the current version of the code.
if asdf_version >= MIN_VERSION_OLD_FILES:
old_file_path = Path(str(tmpdir))/"test-old.asdf"
assert env_run(env_path, "python", GENERATE_SCRIPT_PATH, old_file_path, str(standard_version), capture_output=True), (
assert env_run(env_path, "python3", GENERATE_SCRIPT_PATH, old_file_path, str(standard_version), capture_output=True), (
"asdf library version {} failed to generate an ASDF Standard {} file".format(asdf_version, standard_version)
)
assert_file_correct(old_file_path), (
Expand Down