fix __asdf_traverse__ for non-tagged object #1739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check for a
_tag
attribute before attempting to fetch schema for a node duringNodeSchemaInfo
tree traversal.The current code assumes that any object implementing
__asdf_traverse__
also has a_tag
attribute which contains a valid tag."duck typing" was used here (instead of checking for
isinstance(Tagged)
asroman_datamodels
defines non-Tagged objects that contain valid_tag
attributes.Fixes #1738
The weldx failure is unrelated (caused by a new pandas version) the roman_datamodels failure is addressed in: #1748
Checklist: