Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asdf-unit-schemas from dependencies #1777

Closed
wants to merge 1 commit into from
Closed

Remove asdf-unit-schemas from dependencies #1777

wants to merge 1 commit into from

Conversation

sunpoet
Copy link

@sunpoet sunpoet commented Apr 2, 2024

Description

The schemas provided by asdf-unit-schemas were duplicates of the schemas provided by asdf-standard.

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

The schemas provided by asdf-unit-schemas were duplicates of the schemas
provided by asdf-standard.
@sunpoet sunpoet requested a review from a team as a code owner April 2, 2024 19:35
@braingram
Copy link
Contributor

Thanks for the PR!

The change to pyproject.toml looks good. However there are other references to asdf-unit-schemas in the CI (and other files). This reminded me I had a draft PR with most of the changes. I cleaned that up and brought it out of draft:
#1767
I'm closing this PR in favor of the above one that removes other references to asdf-unit-schemas.

@braingram braingram closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants