Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only check for issue number, to accomodate misc category #1828

Merged
merged 2 commits into from
Aug 19, 2024
Merged

only check for issue number, to accomodate misc category #1828

merged 2 commits into from
Aug 19, 2024

Conversation

zacharyburnett
Copy link
Member

Description

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, added news fragment (changes/<PR#>.<changetype>.rst)
  • for a public change, updated documentation
  • for any new features, unit tests were added

@zacharyburnett zacharyburnett self-assigned this Aug 19, 2024
@zacharyburnett zacharyburnett changed the title only check for issue number to accomodate misc category only check for issue number, to accomodate misc category Aug 19, 2024
@zacharyburnett zacharyburnett mentioned this pull request Aug 19, 2024
Merged
5 tasks
@zacharyburnett zacharyburnett marked this pull request as ready for review August 19, 2024 20:38
@zacharyburnett zacharyburnett requested a review from a team as a code owner August 19, 2024 20:38
braingram
braingram approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@braingram
Copy link
Contributor

:sad trombone: RTD is still unhappy:

The ASDF Standard is at v1.6.0
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../CHANGES.rst:127: CRITICAL: Title level inconsistent:

@braingram braingram merged commit 04cc885 into asdf-format:main Aug 19, 2024
29 of 30 checks passed
@zacharyburnett zacharyburnett deleted the changelog/fix branch August 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @braingram