Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsonschema to 3.0.1 #684

Merged
merged 4 commits into from
Jun 28, 2019
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions asdf/compat/jsonschemacompat.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from ..util import minversion


__all__ = ['JSONSCHEMA_LT_3']


JSONSCHEMA_LT_3 = not minversion('jsonschema', '3.0.0')
22 changes: 19 additions & 3 deletions asdf/schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from . import treeutil
from . import util
from .extension import default_extensions
from .compat.jsonschemacompat import JSONSCHEMA_LT_3


YAML_SCHEMA_METASCHEMA_ID = 'http://stsci.edu/schemas/yaml-schema/draft-01'
Expand Down Expand Up @@ -202,11 +203,26 @@ def validate_remove_default(validator, properties, instance, schema):
@lru_cache()
def _create_validator(validators=YAML_VALIDATORS):
meta_schema = load_schema(YAML_SCHEMA_METASCHEMA_ID, default_ext_resolver)
base_cls = mvalidators.create(meta_schema=meta_schema, validators=validators)

if JSONSCHEMA_LT_3:
base_cls = mvalidators.create(meta_schema=meta_schema, validators=validators)
else:
type_checker = mvalidators.Draft4Validator.TYPE_CHECKER.redefine(
'array',
lambda checker, instance: isinstance(instance, list) or isinstance(instance, tuple)
)
id_of = mvalidators.Draft4Validator.ID_OF
base_cls = mvalidators.create(
meta_schema=meta_schema,
validators=validators,
type_checker=type_checker,
id_of=id_of
)

class ASDFValidator(base_cls):
DEFAULT_TYPES = base_cls.DEFAULT_TYPES.copy()
DEFAULT_TYPES['array'] = (list, tuple)
if JSONSCHEMA_LT_3:
DEFAULT_TYPES = base_cls.DEFAULT_TYPES.copy()
DEFAULT_TYPES['array'] = (list, tuple)

def iter_errors(self, instance, _schema=None, _seen=set()):
# We can't validate anything that looks like an external reference,
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ include_package_data = True
install_requires =
semantic_version>=2.3.1
pyyaml>=3.10
jsonschema>=2.3,<=2.6
jsonschema>=2.3,<4
six>=1.9.0
numpy>=1.8

Expand Down