Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Directory v3 and bump dependencies #39

Merged
merged 16 commits into from
Nov 17, 2023
Merged

add Directory v3 and bump dependencies #39

merged 16 commits into from
Nov 17, 2023

Conversation

gimmyxd
Copy link
Member

@gimmyxd gimmyxd commented Nov 14, 2023

Adds Directory v3 Client
fixes #40 #35

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ec0e9a9) 68.99% compared to head (5f839ee) 73.34%.
Report is 1 commits behind head on main.

Files Patch % Lines
lib/directory/v3/index.ts 93.90% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   68.99%   73.34%   +4.34%     
==========================================
  Files          23       26       +3     
  Lines         687      979     +292     
  Branches      207      264      +57     
==========================================
+ Hits          474      718     +244     
- Misses        213      261      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimmyxd gimmyxd merged commit 4b9cdab into main Nov 17, 2023
5 checks passed
@gimmyxd gimmyxd deleted the dir_v3 branch November 17, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Directory v3 to aserto-node
3 participants