Topaz bugfixes #19
Merged
Topaz bugfixes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix bug in `remote_directory.api_key` causing the string `"Error"`
to be set as the api key.
* Fix bug in discovery configuration causing an invalid `{}` litaral
to be inserted when no `serviceConfig` options are provided.
* Check for mismatched tenant ID value between discovery and edge sync. * Require policy name in discovery config. * Correctly set opa `instance_id` when edge sync is configured but not discovery. * Fix errors when discovery api key is not provided.
gertd
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
http.domainwas generating invalidfdqnfield instead offqdnpolicyNameis omitted inopa.policy.discovery.opa.policy.discovery.tenantIDanddirectory.edge.sync.tenantIDare specified, their values match.{}literal whenopa.policy.discovery.serviceConfigis empty.