fix: properly reflect that default: false makes a non required attr…

…ibute
ash-project · Jun 11, 2024 · d935a45 · d935a45
1 parent 0c93bfb
commit d935a45
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/ash_json_api/json_schema/json_schema.ex b/lib/ash_json_api/json_schema/json_schema.ex
@@ -724,7 +724,7 @@ defmodule AshJsonApi.JsonSchema do
       resource
       |> Ash.Resource.Info.attributes()
       |> Enum.filter(&(&1.name in action.accept && &1.writable?))
-      |> Enum.reject(&(&1.allow_nil? || &1.default || &1.generated?))
+      |> Enum.reject(&(&1.allow_nil? || not is_nil(&1.default) || &1.generated?))
       |> Enum.map(&to_string(&1.name))
 
     arguments =

diff --git a/lib/ash_json_api/json_schema/open_api.ex b/lib/ash_json_api/json_schema/open_api.ex
@@ -950,7 +950,7 @@ if Code.ensure_loaded?(OpenApiSpex) do
         resource
         |> Ash.Resource.Info.attributes()
         |> Enum.filter(&(&1.name in action.accept && &1.writable?))
-        |> Enum.reject(&(&1.allow_nil? || &1.default || &1.generated?))
+        |> Enum.reject(&(&1.allow_nil? || not is_nil(&1.default) || &1.generated?))
         |> Enum.map(& &1.name)
 
       arguments =