Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename examples to ash-examples #820

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Rename examples to ash-examples #820

merged 1 commit into from
Nov 17, 2023

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Nov 15, 2023

Depends on #819

Dependabot complains that:

 the binary target name `examples` is forbidden, it conflicts with with cargo's build directory names

And fails to provide dependency upgrades for Rust code. Fix that by renaming the folder and crate to ash-examples.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I don't think we actually have a binary target by that name, specifically? Probably a dependabot bug, but oh well.

Base automatically changed from readme to master November 17, 2023 15:55
@MarijnS95
Copy link
Collaborator Author

MarijnS95 commented Nov 17, 2023

Weird, I don't think we actually have a binary target by that name, specifically? Probably a dependabot bug, but oh well.

Yeah, I found this suspicious as well but didn't read too much into it because folks like to
call shared objects "binary" as well. That said it should only emit an rlib?

EDIT: But it only matters for executables which have no extension on unix: target/debug/examples as exe would conflict with the folder created for target/debug/examples/{texture,triangle}. Seems unlikely that dependabot can do rigorous "does this crate actually produce a binary" tests based on various rules (autobins, [bin] name = "...", stuff existing in src/bin/, src/main.rs...).

Besides, dependabot is buggy in many more ways (failing to understand < vs <= ranges and bumping the latter to an inexistant version).

Dependabot complains [1] that:

     the binary target name `examples` is forbidden, it conflicts with with cargo's build directory names

And fails to provide dependency upgrades for Rust code.  Fix that by
renaming the folder and crate to `ash-examples`.

[1]: https://github.com/ash-rs/ash/network/updates/748770724
@MarijnS95 MarijnS95 marked this pull request as ready for review November 17, 2023 16:27
@MarijnS95 MarijnS95 merged commit 4bbfa54 into master Nov 17, 2023
22 checks passed
@MarijnS95 MarijnS95 deleted the ash-examples branch November 17, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants