generator: Wrap _as_c_str() getter for possibly-pointers in Option
#860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
approved these changes
Jan 10, 2024
MarijnS95
force-pushed
the
c-str-getter-null
branch
from
c8d86f3
to
f07b662
Compare
Ralith
approved these changes
Jan 11, 2024
While this function is already marked `unsafe` to represent cases where an invalid pointer might be dereferenced, it should at least be obvious to the caller that there is a real chance for `NULL` pointers in these `CStr` getters, which will now be returned as `None`. This function won't be used in `Debug` now as the dereference operation is still `unsafe`. The `_as_c_str()` getters for static arrays is left untouched, as the data is read directly from the known-valid struct here.
MarijnS95
force-pushed
the
c-str-getter-null
branch
from
f07b662
to
db695cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this function is already marked
unsafeto represent cases where an invalid pointer might be dereferenced, it should at least be obvious to the caller that there is a real chance forNULLpointers in theseCStrgetters, which will now be returned asNone. This function won't be used inDebugnow as the dereference operation is stillunsafe.The
_as_c_str()getters for static arrays is left untouched, as the data is read directly from the known-valid struct here.