Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to generated by rust-bindgen 0.69.2 in native.rs #863

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

fornwall
Copy link
Contributor

Fixes the below CI failure:

Error: Generated files are different, please regenerate with cargo run -p generator!
diff --git a/ash/src/vk/native.rs b/ash/src/vk/native.rs
index 223fb73..f28431a 100644
--- a/ash/src/vk/native.rs
+++ b/ash/src/vk/native.rs
@@ -1,4 +1,4 @@
-/* automatically generated by rust-bindgen 0.69.1 /
+/
automatically generated by rust-bindgen 0.69.2 */

#[repr(C)]
#[derive(Copy, Clone, Debug, Default, Eq, Hash, Ord, PartialEq, PartialOrd)]

Fixes the below CI failure:

> Error: Generated files are different, please regenerate with cargo run -p generator!
> diff --git a/ash/src/vk/native.rs b/ash/src/vk/native.rs
> index 223fb73..f28431a 100644
> --- a/ash/src/vk/native.rs
> +++ b/ash/src/vk/native.rs
> @@ -1,4 +1,4 @@
> -/* automatically generated by rust-bindgen 0.69.1 */
> +/* automatically generated by rust-bindgen 0.69.2 */
>
> #[repr(C)]
> #[derive(Copy, Clone, Debug, Default, Eq, Hash, Ord, PartialEq, PartialOrd)]
@MarijnS95
Copy link
Collaborator

MarijnS95 commented Jan 24, 2024

The right fix should be affixing the bindgen version (bindgen = "=0.69.2") in generator/Cargo.toml, so that we don't run into such spurious and unnecessary failures again.

dependabot can point out updates for us.

@fornwall
Copy link
Contributor Author

The right fix should be affixing the bindgen version (bindgen = "=0.69.2") in generator/Cargo.toml, so that we don't run into such spurious and unnecessary failures again.

@MarijnS95 Makes sense - done that in 6172fa7 now.

@Ralith
Copy link
Collaborator

Ralith commented Jan 25, 2024

Might benefit from a comment explaining why it's pinned.

@fornwall
Copy link
Contributor Author

fornwall commented Jan 25, 2024

Might benefit from a comment explaining why it's pinned.

@Ralith Thanks - added a comment in 317c2df.

@Ralith Ralith merged commit 4449a18 into ash-rs:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants