Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for swift package manager #215

Closed
tahirmt opened this issue Jan 9, 2021 · 8 comments · Fixed by #227
Closed

Add support for swift package manager #215

tahirmt opened this issue Jan 9, 2021 · 8 comments · Fixed by #227
Assignees

Comments

@tahirmt
Copy link

tahirmt commented Jan 9, 2021

Can we get SPM support?

@ashfurrow
Copy link
Owner

Sure can! I think that's a great idea. You can open a pull request here.

@tahirmt
Copy link
Author

tahirmt commented Jan 23, 2021

This will be a good addition. Still trying to figure out how to get Swift and Objective-C work together while using SPM

@hfehrmann
Copy link
Collaborator

The problem is that there is a dependency that will not be updated to work with SPM. See #190

@tahirmt
Copy link
Author

tahirmt commented Jun 11, 2021

@ashfurrow I worked on this on a fork by using this fork https://github.com/alanzeino/ios-snapshot-test-case. The main repo is still not updated because uber isn't maintaining the repo. Not sure if we want to add support by using a fork instead of the main repo though so I didn't create a pull request here.

@ashfurrow
Copy link
Owner

Hmm, I can only speak from a CocoaPods perspective, where it's fairly easy to use a fork (by adding the transitive dependency to your Podfile using git to point to the fork). It's a shame Uber isn't maintaining that – I'm glad Alan is on it though.

@tahirmt
Copy link
Author

tahirmt commented Jun 14, 2021

Pointing to a fork with swift package manager is even easier imo. For my fork I only used the fork for the swift package tahirmt#1.

Alan has been trying to get access to the repo and "we should know in a few weeks"
uber/ios-snapshot-test-case#126 (comment)

@dogo dogo self-assigned this Aug 25, 2021
@dogo
Copy link
Collaborator

dogo commented Aug 25, 2021

It's possible now! I'm on it

@dogo
Copy link
Collaborator

dogo commented Aug 26, 2021

Experimental branch feature/spm-support

PR #227

@dogo dogo linked a pull request Aug 26, 2021 that will close this issue
@dogo dogo closed this as completed in #227 Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants