Add spm support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahirmt
force-pushed
the
add-SPM-support
branch
6 times, most recently
from
4b2c102
to
32b4a77
Compare
ketenshi
reviewed
Jun 11, 2021
|
Can you speak to why Swift-Core and Core are needed to get SPM working? |
@ketenshi added a description to the PR explaining this. |
Generated by 🚫 Danger |
ketenshi
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPM does not support mixing Objective-C and Swift in one target. To get around this limitation we now define multiple targets that are swift and objc exclusive.
Nimble-Snapshots-Swift-Coreis needed so we can exposeCurrentTestCaseTrackerto Objective-C as we need to register it in theloadfunction which isn't supported by swift.Nimble-Snapshots-Corecontains all the Objective-C code importing the swift core framework.Finally, the product
Nimble_Snapshotsimports both of these and creates one binary that the consumers can use.We also use
@_exported importfor the internal frameworks so consumers don't need to import them to use the code.