Skip to content

Commit

Permalink
opentracing: remove legacy open tracing extension (envoyproxy#35418)
Browse files Browse the repository at this point in the history
Risk Level: medium
Testing: n/a
Docs Changes:
Release Notes: inline
Fixes envoyproxy#27401
Fixes envoyproxy#34321

---------

Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: asingh-g <[email protected]>
  • Loading branch information
alyssawilk authored and asingh-g committed Aug 20, 2024
1 parent a186a5f commit c59f9b6
Show file tree
Hide file tree
Showing 17 changed files with 6 additions and 963 deletions.
4 changes: 2 additions & 2 deletions api/envoy/config/trace/v3/dynamic_ot.proto
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;

// [#protodoc-title: Dynamically loadable OpenTracing tracer]

// DynamicOtConfig is used to dynamically load a tracer from a shared library
// DynamicOtConfig was used to dynamically load a tracer from a shared library
// that implements the `OpenTracing dynamic loading API
// <https://github.com/opentracing/opentracing-cpp>`_.
// [#extension: envoy.tracers.dynamic_ot]
// [#not-implemented-hide:]
message DynamicOtConfig {
option (udpa.annotations.versioning).previous_message_type =
"envoy.config.trace.v2.DynamicOtConfig";
Expand Down
159 changes: 0 additions & 159 deletions bazel/io_opentracing_cpp.patch

This file was deleted.

4 changes: 4 additions & 0 deletions changelogs/current.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ date: Pending

behavior_changes:
# *Changes that are expected to cause an incompatibility if applicable; deployment changes are likely required*
- area: tracing
change: |
Removed support for (long deprecated) opentracing. See `issue 27401
<https://github.com/envoyproxy/envoy/issues/27401>`_ for details.
minor_behavior_changes:
# *Changes that may cause incompatibilities for some users, but should not for most*
Expand Down
1 change: 0 additions & 1 deletion source/extensions/extensions_build_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ EXTENSIONS = {
# Tracers
#

"envoy.tracers.dynamic_ot": "//source/extensions/tracers/dynamic_ot:config",
"envoy.tracers.datadog": "//source/extensions/tracers/datadog:config",
"envoy.tracers.zipkin": "//source/extensions/tracers/zipkin:config",
"envoy.tracers.opencensus": "//source/extensions/tracers/opencensus:config",
Expand Down
7 changes: 0 additions & 7 deletions source/extensions/extensions_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1201,13 +1201,6 @@ envoy.tracers.datadog:
status: stable
type_urls:
- envoy.config.trace.v3.DatadogConfig
envoy.tracers.dynamic_ot:
categories:
- envoy.tracers
security_posture: unknown
status: stable
type_urls:
- envoy.config.trace.v3.DynamicOtConfig
envoy.tracers.opencensus:
categories:
- envoy.tracers
Expand Down
33 changes: 0 additions & 33 deletions source/extensions/tracers/common/ot/BUILD

This file was deleted.

Loading

0 comments on commit c59f9b6

Please sign in to comment.