generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement --build_python_zip pex #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
commented
Apr 2, 2024
thesayyn
force-pushed
the
build_python_zip
branch
2 times, most recently
from
May 21, 2024 22:45
db0db35
to
3391a90
Compare
dizzy57
reviewed
May 23, 2024
mattem
requested changes
May 23, 2024
mattem
reviewed
Jun 3, 2024
I was unable to make it work with bzlmod, here's a minimal repro: https://github.com/dizzy57/bazel_py_minimal
|
thesayyn
force-pushed
the
build_python_zip
branch
from
June 20, 2024 10:17
5ec8c91
to
814d7a2
Compare
mattem
reviewed
Jul 19, 2024
This was referenced Aug 20, 2024
Also, CPython=={major}.{minor}.* should be the default constraint. |
@mattem I have removed some unrelated diff from my failed attempt before using PEX. Now diff should be smaller and easier to understand. |
dizzy57
reviewed
Sep 4, 2024
dizzy57
reviewed
Sep 4, 2024
mattem
reviewed
Sep 4, 2024
dizzy57
reviewed
Sep 4, 2024
mattem
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
--build_python_zip
seems to not work in py_binary #236)Test plan