Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ts_project does not support root_dir = ".." #551

Closed
jgao54 opened this issue Feb 22, 2024 · 0 comments · Fixed by #552
Closed

[Bug]: ts_project does not support root_dir = ".." #551

jgao54 opened this issue Feb 22, 2024 · 0 comments · Fixed by #552
Assignees
@jbedard
Labels
bug Something isn't working

Comments

@jgao54
Copy link

jgao54 commented Feb 22, 2024 •
edited
Loading

What happened?

When root_dir is set to "..", instead of a successful build, got vague errors like:

output 'scripts/script_2.js' was not created
Transpiling TypeScript project @//scripts:bad [tsc -p scripts/tsconfig_bad.json] failed: not all outputs were created or valid
Target //scripts:bad failed to build

Version

Development (host) and target OS/architectures:

Output of bazel --version:

  • 7.0.2

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

  • rules_ts-v2.1.1
  • bazel-lib-v1.40.0

Language(s) and/or frameworks involved:

  • typescript

How to reproduce

Minimum Repro: https://github.com/jgao54/rule-ts-bug-minimum-repro/tree/main

Any other information?

No response
@jgao54 jgao54 added the bug Something isn't working label Feb 22, 2024
@github-actions github-actions bot added the untriaged Requires traige label Feb 22, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Feb 23, 2024
@jbedard
feat: add ts_project validation of root/out/typing_out dir options
2b95088 
Close aspect-build#551
@jbedard jbedard mentioned this issue Feb 23, 2024
Merged
@jbedard jbedard self-assigned this Feb 23, 2024
@jbedard jbedard removed the untriaged Requires traige label Feb 23, 2024
jbedard added a commit that referenced this issue Feb 26, 2024
@jbedard
feat: add ts_project validation of root/out/typing_out dir options (#552
9eed754 
)

Close #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
bug Something isn't working
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ts_project validation of root/out/typing_out dir options jbedard/rules_ts
2 participants
@jbedard @jgao54