Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: build_test is always a cache hit #567

Closed
alexeagle opened this issue Mar 15, 2024 · 1 comment · Fixed by #568
Closed

[Bug]: build_test is always a cache hit #567

alexeagle opened this issue Mar 15, 2024 · 1 comment · Fixed by #568
Labels
bug Something isn't working untriaged Requires traige

Comments

@alexeagle
Copy link
Member

What happened?

Looking at examples/transpiler in this repo, the inputs to the babel_typecheck_test are

% bazel aquery //examples/transpiler:babel_typecheck_test | grep Inputs
  Inputs: [bazel-out/k8-fastbuild/bin/examples/transpiler/babel_typecheck_test.sh, bazel-out/k8-fastbuild/bin/examples/transpiler/babel_typecheck_test.sh.runfiles/MANIFEST, bazel-out/k8-fastbuild/bin/examples/transpiler/babel_typecheck_test_0__deps.out]

that babel_typecheck_test_0__deps.out file is an empty marker file. This means that this test doesn't ever fail, and it's always a cache hit once it has run. It only forces some build actions to be added to the graph - if the target doesn't type-check, it's a build failure, not a test failure.

Version

HEAD as of today

How to reproduce

No response

Any other information?

No response
@alexeagle alexeagle added the bug Something isn't working label Mar 15, 2024
@github-actions github-actions bot added the untriaged Requires traige label Mar 15, 2024
@alexeagle
Copy link
Member Author

Underlying cause: bazelbuild/bazel-skylib#480

alexeagle added a commit that referenced this issue Mar 15, 2024
@alexeagle
fix: typecheck_test depends on the .d.ts files
f2ef6d2 
Fixes #567
@alexeagle alexeagle mentioned this issue Mar 15, 2024
Merged
alexeagle added a commit that referenced this issue Mar 18, 2024
@alexeagle
fix: typecheck_test depends on the .d.ts files (#568)
f5df58c 
* fix: typecheck_test depends on the .d.ts files

Fixes #567

* Update build_test.bzl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged Requires traige
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typecheck_test depends on the .d.ts files aspect-build/rules_ts
1 participant
@alexeagle