Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ts_project error when srcs include parent/sibling files #727

Closed
jbedard opened this issue Oct 31, 2024 · 0 comments · Fixed by #729
Closed

[Bug]: ts_project error when srcs include parent/sibling files #727

jbedard opened this issue Oct 31, 2024 · 0 comments · Fixed by #729
Assignees
Labels
bug Something isn't working

Comments

@jbedard
Copy link
Member

jbedard commented Oct 31, 2024

What happened?

When the ts_project(srcs) is passed files that do not belong to the current BUILD odd errors occur.

  1. passing .ts from parent/sibling packages:

Previous, before 85d969e, tsc would output an error saying the .ts is outside the rootDor.

After 85d969e write_tsconfig computes the wrong path and tsc outputs an error saying the file doesn't exist instead.

  1. passing .ts from subpackages

GUESS: tsc will not complain about the inputs but will most likely fail to write the outputs.

  1. passing .d.ts from parent/sibling packages:

Previously: may have passed depending if the dts is already in the bindir (so no copy action is created)
Now: probably fails because the path is computed wrong

Version

All, the error changed after 85d969e

How to reproduce

jbedard@ebb4759

@jbedard jbedard added the bug Something isn't working label Oct 31, 2024
@jbedard jbedard self-assigned this Oct 31, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 31, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 31, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Nov 4, 2024
@jbedard jbedard closed this as completed in e852fc0 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant