Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ts_project with transpiler and no declarations for type-checking #698

Merged
merged 1 commit into from
Sep 21, 2024
Merged

feat: support ts_project with transpiler and no declarations for type-checking #698

merged 1 commit into from
Sep 21, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Sep 20, 2024

Now that --noEmit can be used to typecheck without any output files it can also be used when a custom transpiler is used along with no dts outputs.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Sep 20, 2024 •
edited
Loading

Test

All tests were cache hits

91 tests (100.0%) were fully cached saving 8s.

Buildifier      Format

DavidZbarsky-at
DavidZbarsky-at approved these changes Sep 20, 2024
View reviewed changes
ts/private/ts_lib.bzl Outdated Show resolved Hide resolved
@jbedard jbedard mentioned this pull request Sep 20, 2024
Merged
@jbedard jbedard force-pushed the allow-no-outs branch 3 times, most recently from cee5c51 to 48c472b Compare September 20, 2024 20:19
@jbedard jbedard marked this pull request as ready for review September 20, 2024 20:22
@jbedard jbedard force-pushed the allow-no-outs branch 3 times, most recently from 8a4e3b2 to a5f5ffc Compare September 20, 2024 21:04
dzbarsky
dzbarsky approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@dzbarsky dzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only skimmed the example, rule change lgtm

gregmagolan
gregmagolan approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbedard
feat: support ts_project for only type-checking
70c3b5b 
Possible scenarios include: noEmit, transpiler+noEmitDeclarations.
@jbedard jbedard merged commit 7cdd9a5 into aspect-build:main Sep 21, 2024
23 checks passed
@jbedard jbedard deleted the allow-no-outs branch September 21, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@dzbarsky dzbarsky dzbarsky approved these changes

@DavidZbarsky-at DavidZbarsky-at Awaiting requested review from DavidZbarsky-at

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbedard @gregmagolan @dzbarsky @DavidZbarsky-at