Add fixture for declaration transpiler test #708
Conversation
|
|
|
MichaelMitchell-at
force-pushed
the
declaration_transpiler_test_fixture
branch
2 times, most recently
from
7006a7c
to
1e88035
Compare
MichaelMitchell-at
force-pushed
the
declaration_transpiler_test_fixture
branch
from
1e88035
to
19b3a9a
Compare
| ) | ||
|
|
||
| ctx.actions.write( | ||
| output = map_file, | ||
| content = _DUMMY_SOURCEMAP % src.short_path, | ||
| ) | ||
|
|
||
| return DefaultInfo(files = depset(out_files)) |
There was a problem hiding this comment.
Why did this have to switch? The transpiler should just have to output the transpiled js or dts (+maps) as default info?
There was a problem hiding this comment.
Having JsInfo seems typical of actual usage. Some examples:
There was a problem hiding this comment.
That just means the rule can be used directly for things like js_library(deps) I guess, instead of how ts_project (the macro) or js_library(srcs) uses the DefaultInfo.
I guess it does not harm, but also isn't used in these tests 🤷
There was a problem hiding this comment.
Yeah it's probably worth doing in case folks crib this as an example (though we could also provide a production-ready transpiler using oxc as an example ;)
I haven't quite figured out how or what to test, but I figure adding a dummy transpiler based on what we have at Airtable could be helpful.
Changes are visible to end-users: no
Test plan