Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support --incompatible_disallow_empty_glob #731

Merged
merged 5 commits into from
Nov 1, 2024
Merged

fix: support --incompatible_disallow_empty_glob #731

merged 5 commits into from
Nov 1, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Nov 1, 2024 •
edited
Loading

This flag was flipped for Bazel 8. Need this for rules_ts rollout at a client.

@alexeagle
fix: support --incompatible_disallow_empty_glob
83cf6f6 
This flag was flipped for Bazel 8
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Nov 1, 2024 •
edited
Loading

Test

3 test targets passed

Targets 
//docs:update_0_test [k8-fastbuild] 27ms
//docs:update_1_test [k8-fastbuild] 25ms
//docs:update_2_test [k8-fastbuild] 28ms

Total test execution time was 80ms. 143 tests (97.9%) were fully cached saving 9s.

Buildifier      Format

@alexeagle alexeagle merged commit 60a3e9f into main Nov 1, 2024
24 checks passed
@alexeagle alexeagle deleted the alexeagle-patch-1 branch November 1, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

@dzbarsky dzbarsky Awaiting requested review from dzbarsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @jbedard