Treat non-web apps as first class, not requiring appSettings hack. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 3.6 update, we botched the handling of the "aspnet:RoslynCompilerLocation" appSetting. Prior to that version, we
would add that value to app.config files, but not web.config. With the update, we started treating all config files the same,
not adding that setting anymore.
Web apps have a 'bin' directory where all their assemblies get deployed. We also deploy roslyn to this bin directory.
Non-web apps don't have 'bin', but instead just a base AppDomain directory. This is where we deploy roslyn in non-web scenarios.
Instead of requiring a silly 'aspnet:*' appSetting for non-aspnet apps to use this package, let's just check the appdomain base
directory as a default location.