-
Notifications
You must be signed in to change notification settings - Fork 224
dnx requiring "run" can be improved a bit #1403
Comments
And if there's a folder called run. We can just ignore it? What about the other commands? |
I would love if we could change it to If you have a folder named run it'll be |
Ya, this all started with the whole "dnx ." thing and I came here to open another bug but found this. When I went "dnx web" I get a lousy error "Please specify the command to run" and I just stared. I agree with @Mpdreamz we should do "dnx command [directory]" so the default is . @glennc @danroth27 @DamianEdwards (or at the absolute minimum, change the error to tell folks about the . ) |
Yeah, was talking with @anurse about this the other day too. Specifying the project dir would probably move to a switch, because things coming after the "command" should be treated as string[] args. And the main use-case would still be to default to the current working directory, so you'd almost never be exposed to the project dir switch. |
My thought was that
Possible "Host Options" include:
The first argument that doesn't start with When DNX starts up, it uses the There is a small exception, which is that if If you want to run commands from another project, you just do |
It's worth noting that changing this might break visual studio /cc @sayedihashimi @PradeepKadubandi @BillHiebert |
I really like the look of @anurse's proposed changes. |
+1 and agreed such a change would need to be coordinated pretty carefully |
I like this also. The 90% case has to be as easy as possible. "mono foo," On Wed, May 20, 2015 at 1:08 PM, Louis DeJardin [email protected]
Scott Hanselman |
We'll go with @anurse's suggestion. We need to ensure tooling doesn't break. Also let's keep |
Tooling will need to be updated to handle the changes. We should be able to do it in a compatible way that continues to support the old syntax for older versions of DNX. |
@BillHiebert I dont think it will affect tooling. Can you tell us how you're launching things today? I believe you're passing in the full path including the --appbase flag which should continue to work. |
I think you are right. We would continue to pass in the -appbase and --lib like we do today. |
Why do we need to support older versions? It hasn't been released and there On Tue, Jul 7, 2015 at 10:31 AM, BillHiebert [email protected]
Scott Hanselman |
To avoid pissijg people off we stage changes like these. If a nightly build breaks your vs then we want to line it up with a VS release |
Sure, but we aren't even releasing yet. We have some time, no? I say break On Tue, Jul 7, 2015 at 11:36 AM, David Fowler [email protected]
Scott Hanselman |
@davidfowl @shanselman @DamianEdwards @anurse @muratg - in my PR I kept the ability to specify a folder (including |
Since we can't break tooling, I think we need to keep it. On Wed, Jul 15, 2015 at 11:11 AM, Pawel Kadluczka [email protected]
Scott Hanselman |
We may be OK from the tooling perspective. Last I heard the tooling was always specifying |
Of course we should verify this :) |
Based on a talk with @davidfowl early this morning, postponing this to beta 7. We'll also start integrating with tooling on a much higher frequency soon so we'll find any breaking issues ASAP. It's just late to check this in beta 6. |
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
Before providing appbase folder was necessary. Now we don't expect a folder anymore but assume that the current folder is the appbase folder. The only exception is where for backwards compatibility we continue to recognize `.` (so `dnx . run` continues to work). If the user really wants to provide a folder that is not the current folder they need to use the --appbase parameter. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
Before providing appbase folder was necessary. Now we don't expect a folder anymore but assume that the current folder is the appbase folder. The only exception is where for backwards compatibility we continue to recognize `.` (so `dnx . run` continues to work). If the user really wants to provide a folder that is not the current folder they need to use the --appbase parameter. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
dnx path-to-project.json run
is a bit redundant - if you name the project file or folder, and there are no arguments, it can be implied.On the other hand, if
dnx run
can use the current directory as the project then that does make sense, and looks cleaner thandnx . run
ordnx project.json run
The text was updated successfully, but these errors were encountered: