Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

PackageManager should use System.Net.Http on CoreCLR #643

Closed
pranavkm opened this issue Sep 18, 2014 · 9 comments
Closed

PackageManager should use System.Net.Http on CoreCLR #643

pranavkm opened this issue Sep 18, 2014 · 9 comments
Assignees
Milestone

Comments

@pranavkm
Copy link
Contributor

The System.Net.Http package has a HttpClient which would be the replacement for Microsoft.Net.HttpClient.

@pranavkm
Copy link
Contributor Author

Note: I tried switching it over but there's a bug in HttpClient which causes it throw ObjectDisposedException if you reuse it for requests. This prevents us from using it at this point. @Tratcher could you let us know when the bug might be fixed so we can start using it?

@pranavkm pranavkm added the bug label Sep 18, 2014
@Tratcher
Copy link
Member

Yes, lets try this again in a few weeks.

@Praburaj
Copy link
Contributor

@pranavkm - This HttpClient bug is fixed now. Can we try this?

@ChengTian
Copy link
Contributor

Hi @pranavkm , I am trying this change again but cannot find the class WebProxy in System.Net.Http.4.0.0.0 or System.Net.Primitives.4.0.10.0 package. When you was making this change, where did you find WebProxy, which is needed by kpm restore?

@muratg
Copy link
Contributor

muratg commented Feb 10, 2015

@ChengTian @pranavkm what's the status of this issue?

@ChengTian
Copy link
Contributor

Buggy HttpClient from CoreCLR was preventing this from being done. I will try integrating the latest CoreCLR HttpClient to see whether it usable now.

@muratg
Copy link
Contributor

muratg commented Mar 6, 2015

@glennc do we need this in RC1?

@ChengTian
Copy link
Contributor

@danroth27 talked to me and we should keep trying to integrate HttpClient from CoreCLR and filing bugs if we can catch any with dnu restore. Putting this to beta6.

@ChengTian
Copy link
Contributor

Still waiting for bug fix from CoreCLR team: https://github.com/dotnet/corefx/issues/2168

The purpose of this task is testing HttpClient on CoreCLR and it is not an urgent issue. Moving to next milestone. @muratg

@ChengTian ChengTian added this to the 1.0.0-beta7 milestone Jun 30, 2015
@ChengTian ChengTian removed this from the 1.0.0-beta6 milestone Jun 30, 2015
@ChengTian ChengTian changed the title PackageManager should use System.Net.Http PackageManager should use System.Net.Http on CoreCLR Aug 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants