DTH should return .csproj file instead of wrapper project.json for references #945
Comments
- Added WrappedProject to TargetFrameworkInformation - Return the wrapped project file or assembly instead of a project reference where appropriate. #945
- Added WrappedProject to TargetFrameworkInformation - Return the wrapped project file or assembly instead of a project reference where appropriate. #945
|
Though this is fixed in general, there is one more issue. For a non-compatible framework, (Web project has aspnetcore50 whereas .csproj is only targeting net45) and if the user added the dependency to a common section, DTH should return the reference as unresolved for non-compatible framework, however right now it's returning the wrapped project.json for non-compatible framework and returning the backing .cspoj for compatible framework. Also one more issue - Only the 'References' message is fixed to return the .csproj, the 'Dependencies' message is still returning the wrapped project.json - can you fix that too? I have an idea - I can add a context menu 'wrap' on a csproj reference inside the references node. Opening the issue to fix both the above. |
- Fix up the dependencies list when returning wrapped csproj and assemblies. - Changed how unresolved dependencies were implemented. This allows a specific IDependencyProvider to say a dependency is resolved, but mark it as unresolved so that fallback does not happen. - Remove special logic from the UnresolvedDependencyProvider and made it a first class property on LibraryDescription. - Mark projects as unresolved if they do not have a compatible target framework #945
- Fix up the dependencies list when returning wrapped csproj and assemblies. - Changed how unresolved dependencies were implemented. This allows a specific IDependencyProvider to say a dependency is resolved, but mark it as unresolved so that fallback does not happen. - Remove special logic from the UnresolvedDependencyProvider and made it a first class property on LibraryDescription. - Mark projects as unresolved if they do not have a compatible target framework #945
|
@davidfowl can this be closed? |
|
@PradeepKadubandi is this OK to close? |
|
Looks like Dependencies issue is also fixed after Fowler's check-ins. Closing this one. |
If k projects reference csproj, right now DTH sends the wrapped project.json in the references message. It should instead send the .csproj that's being wrapped.
The text was updated successfully, but these errors were encountered: