This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
#2 : Low hanging fruit performance improvements from profiling session #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -222,11 +222,8 @@ public void Initialize(IEnumerable<LibraryDescription> packages, FrameworkName t | |||
| { | |||
| var defaultHashPath = defaultResolver.GetHashPath(package.Id, package.Version); | |||
There was a problem hiding this comment.
This change isn't good enough. Take a look at the performance branch. It avoids any disk IO in the most common case.
There was a problem hiding this comment.
I see. I will check that out.
There was a problem hiding this comment.
what's the strategy for not reading sha512? are we putting the base64 hash bytes in the lock.json written by restore?
There was a problem hiding this comment.
I had a look at the perfomance_stuff branch change on this. I probably need to understand this a bit better. It looks like you still do a disk read to read the contents of the file in for loop during the first time. Am I missing something here?
|
@davidfowl - updated PR. |
Bug# #1147 Addresses: ResolvePackagePath reads sha512 files from the disk when it doesn't need to. Regex use in SemanticVersion and VersionUtility.ParseFrameworkName should be removed. Regex has been replaced with regular string comparison in few more places. Now except PathResolver there are no more Regex usages in xre - that will probably be removed with new globbing.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #1147
Addresses:
ResolvePackagePath reads sha512 files from the disk when it doesn't need to.
Regex use in SemanticVersion and VersionUtility.ParseFrameworkName should be removed. Regex has been replaced with regular string comparison in few more places. Now except PathResolver there are no more Regex usages in xre - that will probably be removed with new globbing.
Will plan to add a few unit tests with the next checkin.
/CC @davidfowl