fix #1113 by adding 'dnu feeds list' command #2121
Conversation
|
|
||
| [Theory] | ||
| [MemberData(nameof(RuntimeComponents))] | ||
| public void DnuSources_ListsAllSources(string flavor, string os, string architecture) |
There was a problem hiding this comment.
I'm not 100% happy with this test. It's a little too brittle. I might see if I can tidy it up before pushing.
|
Oh no! Please don't add |
|
|
||
| namespace Microsoft.Framework.PackageManager | ||
| { | ||
| internal static class SourcesCommand |
There was a problem hiding this comment.
SourcesConsoleCommand
|
Ok, but |
|
I'm not sure I like I'm definitely open to renaming this though if people think that would be less confusing. We could do something like |
| @@ -0,0 +1,44 @@ | |||
| using System; | |||
|
⌚ |
| else | ||
| { | ||
| Reports.Information.WriteLine("Registered Sources:"); | ||
| // Iterate over the sources and report them |
There was a problem hiding this comment.
Nit: add empty line before comment
|
Fix tests! |
|
I'm going to rename this to |
|
Ping @troydai @BrennanConroy @victorhurdugaci - Updated to resolve feedback. |
| { | ||
| internal class ListSourcesCommand | ||
| { | ||
| public Reports Reports { get; set; } |
There was a problem hiding this comment.
This seems to be required and if it null it will fail. Why don't you pass it as a constructor arg ?
There was a problem hiding this comment.
Just because everything else did it this way :). I'll fix this one
|
Ping @victorhurdugaci again :) |
analogrelay
changed the title
|
My concerns are addressed. |
|
I can't figure out what's wrong with the PR builds. I'm going to give a private TeamCity build a quick shot but if I can't work that out, just YOLO push and be prepared to revert :). |
analogrelay
force-pushed
the
anurse/1113-dnu-sources
branch
from
b6124c1
to
7a0faf5
Compare
analogrelay
force-pushed
the
anurse/1113-dnu-sources
branch
from
7a0faf5
to
36eab9f
Compare
Fixes #1113
Add
dnu sourcescommand that lists active sources. It looks like this:Disabled sources have
[Disabled]next to them in yellow to identify them as disabled. I also tried to centralize some of the disjointed code we have to handle NuGet.config./cc @davidfowl @victorhurdugaci @troydai