This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Fixed nuget version casing mismatch #2971
Closed
+37
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always update the nuspec with the resolved version and id on install. #2970
| "dnx451": { } | ||
| }, | ||
| "dependencies": { | ||
| "Contentful.NET": "0.0.5-Alpha" |
There was a problem hiding this comment.
Does this test depend on this package being on NuGet?
There was a problem hiding this comment.
Yes, like all of our other tests and our source code 😄
There was a problem hiding this comment.
I think other tests mostly depend on packages we kind of control, no?
| @@ -77,23 +77,21 @@ internal static class NuGetPackageUtils | |||
| // Fixup the casing of the nuspec on disk to match what we expect | |||
| var nuspecFile = Directory.EnumerateFiles(targetPath, "*" + NuGet.Constants.ManifestExtension).Single(); | |||
| if (!string.Equals(nuspecFile, targetNuspec, StringComparison.Ordinal)) | |||
There was a problem hiding this comment.
Have you considered doing IgnoreCase check and printing the warning if the names still don't match? (I don't feel very strongly about about that though...)
There was a problem hiding this comment.
Nah, doesn't matter. If we found it then we should use it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install.
KeyNotFoundException when running dnu restore with Contentful.NET package #2970