Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(assert): Allow comparing json to jsonlines #350

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat(assert): Allow comparing json to jsonlines #350

merged 4 commits into from
Jul 23, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Jul 23, 2024

Fixes #348

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 23, 2024
View reviewed changes
crates/snapbox/src/data/mod.rs Fixed Show fixed Hide fixed
crates/snapbox/src/data/mod.rs Fixed Show fixed Hide fixed
crates/snapbox/src/data/mod.rs Fixed Show fixed Hide fixed
crates/snapbox/src/data/mod.rs Fixed Show fixed Hide fixed
crates/snapbox/src/data/mod.rs Fixed Show fixed Hide fixed
crates/snapbox/src/data/mod.rs Fixed Show fixed Hide fixed
@coveralls
Copy link

coveralls commented Jul 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10063786982

Details

  • 7 of 28 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 51.542%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/snapbox/src/data/filters.rs 2 5 40.0%
crates/snapbox/src/data/mod.rs 3 21 14.29%
Totals Coverage Status
Change from base Build 10061384392: -0.3%
Covered Lines: 1404
Relevant Lines: 2724
💛 - Coveralls

@epage epage mentioned this pull request Jul 23, 2024
Closed
@epage epage merged commit 5211c64 into assert-rs:main Jul 23, 2024
15 checks passed
@epage epage deleted the convert branch July 23, 2024 19:07
@epage epage mentioned this pull request Aug 14, 2024
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Aug 15, 2024
@bors
Auto merge of #14402 - epage:snap, r=weihanglo
9a170d7 
test: Migrate some json tests to snapbox

### What does this PR try to resolve?

This is part of #14039

### How should we test and review this PR?

### Additional information

This was unblocked because of assert-rs/snapbox#350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easier to diff, prettier rendering for jsonlines
2 participants
@epage @coveralls