Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageContainer #78

Merged
merged 12 commits into from
Sep 24, 2024
Merged

PageContainer #78

merged 12 commits into from
Sep 24, 2024

Conversation

DavidFyon
Copy link
Collaborator

@DavidFyon DavidFyon commented Sep 23, 2024

Description

PageContainer - Synpase

Playground

<script setup lang="ts">
import PageContainer from '@/components/PageContainer/PageContainer.vue'
</script>

<template>
  <VApp>
    <main>
      <PageContainer size="s" color="blue">
        <h1>Playground</h1>
      </PageContainer>
      <PageContainer size="m" color="red">
        <h1>Playground</h1>
      </PageContainer>
      <PageContainer size="l" color="orange">
        <h1>Playground</h1>
      </PageContainer>
      <PageContainer size="xl" color="pink">
        <h1>Playground</h1>
      </PageContainer>
      <PageContainer color="yellow" spacing="sm">
        <h1>Playground</h1>
      </PageContainer>
    </main>
  </VApp>
</template>

Type de changement

  • Nouvelle fonctionnalité
  • Documentation
  • Ce changement nécessite une mise à jour de la documentation

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Le composant est conforme aux maquettes (tokens)
  • Le composant est fonctionnel
  • Le composant est responsive (mobile, tablet et desktop)
  • Le composant répond aux critères d'accessibilité (test Tanaguru + A11y linter)
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai mis en place une stories pour ma fonctionnalité / fix /...
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications

@DavidFyon DavidFyon self-assigned this Sep 23, 2024
@DavidFyon DavidFyon linked an issue Sep 23, 2024 that may be closed by this pull request
10 tasks
Copy link
Contributor

@VachetVirginie VachetVirginie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est ce normal les modif sur Alert?

src/components/Alert/Alert.vue Outdated Show resolved Hide resolved
src/components/PageContainer/PageContainer.vue Outdated Show resolved Hide resolved
@DavidFyon DavidFyon merged commit 59e9a53 into dev Sep 24, 2024
2 checks passed
@DavidFyon DavidFyon deleted the feat/page-container branch September 24, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageContainer
2 participants