Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to leave fullscreen mode on touchscreen desktop without keyboard #81

Closed
klues opened this issue Jan 28, 2021 · 4 comments
Closed

Impossible to leave fullscreen mode on touchscreen desktop without keyboard #81

klues opened this issue Jan 28, 2021 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers priority
Milestone
Keyboard

Comments

@klues
Copy link
Contributor

klues commented Jan 28, 2021

Currently there are the following possibilities to leave fullscreen mode:

  • Press Esc on keyboard
  • Swipe down from top on mobile platform

There should also be a possibility to leave fullscreen without keyboard on desktop.
@klues klues added bug Something isn't working priority labels Jan 28, 2021
@klues klues added good first issue Good for newcomers and removed priority labels Mar 29, 2023
@ms-mialingvo ms-mialingvo added this to the Keyboard milestone Sep 15, 2024
@ms-mialingvo
Copy link
Collaborator

Leave fullscreen through an element/button that does that action. No swiping, no esc.

klues added a commit that referenced this issue Sep 19, 2024
@klues
added new GridActionSystem.js for entering/leaving fullscreen and set…
717d2da 
…ting system volume, #420, #81
klues added a commit that referenced this issue Sep 19, 2024
@klues
use youtube volume label, #420, #81
66008fb
klues added a commit that referenced this issue Sep 19, 2024
@klues
speak with system volume, #420, #81
585b871
klues added a commit that referenced this issue Sep 19, 2024
@klues
added volume to local user settings, #420, #81
18ed841
klues added a commit that referenced this issue Sep 19, 2024
@klues
removed unused props, #420, #81
89fe7a0
klues added a commit that referenced this issue Sep 19, 2024
@klues
set default to prop, #420, #81
f80420a
klues added a commit that referenced this issue Sep 19, 2024
@klues
use systemActionService for fullscreen, auto-update metadata, #420, #81
5a65f51
klues added a commit that referenced this issue Sep 19, 2024
@klues
use systemActionService for fullscreen, #420, #81
2dd2228
klues added a commit that referenced this issue Sep 19, 2024
@klues
added system volume settings to youtube player, mute youtube player i…
91a7081 
…f volume is 0 (yt player bug leaves it at 5%), #420, #81
klues added a commit that referenced this issue Sep 19, 2024
@klues
added system volume settings to webradio player, #420, #81
34f6f36
klues added a commit that referenced this issue Sep 19, 2024
@klues
added debug messages for volume, #420, #81
7e9ea9e
@klues
Copy link
Contributor Author

klues commented Sep 19, 2024

I've added the possibility to enter/leave fullscreen via the new System action.
Also released to "latest", test it with the configuration from this comment, where I've also added elements to enter/leave fullscreen to the global grid.

@ms-mialingvo
Copy link
Collaborator

Awesome, it works, thank you!

@klues
Copy link
Contributor Author

klues commented Oct 10, 2024

released with https://github.com/asterics/AsTeRICS-Grid/releases/tag/release-2024-10-10-09.52%2F%2B0200

@klues klues closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers priority
Projects
None yet
Milestone
Keyboard
Development

No branches or pull requests
2 participants
@klues @ms-mialingvo