Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetricTracker #394

Merged
merged 8 commits into from
Feb 2, 2021
Merged

Add MetricTracker #394

merged 8 commits into from
Feb 2, 2021

Conversation

mpariente
Copy link
Collaborator

Just because it's less code duplicate and it seems useful.
Inspired by the WerTracker in #329.

@mpariente
Copy link
Collaborator Author

@JorisCos @jonashaag some feedback?

@jonashaag
Copy link
Collaborator

VERY quick code review, looks ok, maybe remove the dumping (CSV/JSON) code entirely and let the user to it? It's only an additional .to_csv() call to be done by the user

@jonashaag
Copy link
Collaborator

At some point I will try to think of an integration of this into System for live metrics. Right now I have something similar in my recipes

@mpariente
Copy link
Collaborator Author

At some point I will try to think of an integration of this into System for live metrics. Right now I have something similar in my recipes

Yes, using Lightning for evaluation would really make things simple, and help us get rid on bash..

@mpariente
Copy link
Collaborator Author

Thanks for the review.

@mpariente
Copy link
Collaborator Author

mpariente commented Feb 2, 2021

Resolved conflicts and clean things up.

We should converge on a format for the output (dataframe, aggregate final results in dictionnary, dump to JSON, autogenerate markdown table).
Let's merge this PR and #414 and work on a common interface to both. Should we integrate WER in the metrics?

@mpariente mpariente merged commit 24e7636 into master Feb 2, 2021
@mpariente mpariente deleted the metric_tracker branch February 2, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants