Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies to torch 2.x and lightning 2.x #682

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Upgrade dependencies to torch 2.x and lightning 2.x #682

merged 8 commits into from
Oct 12, 2023

Conversation

mpariente
Copy link
Collaborator

This PR finally upgrades the dependencies and fixes the issues related to it. In particular :

  • Remove the optimizer_idx in lr_scheduler_step in System.
  • Replace torch.symeigh by torch.linalg.eigh in beamforming.py
  • Disable X-UMX as it uses torch1.x STFT : @r-sawata do you want to fix it ?
  • Replace on_*_end with on_training_*_end
  • Replace torch.testing.assert_allclose with torch.testing.assert_close.

@mpariente mpariente merged commit fc13514 into master Oct 12, 2023
9 checks passed
@mpariente mpariente deleted the update_torch_and_lightning branch October 12, 2023 20:40
@DavidDiazGuerra DavidDiazGuerra mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpariente