Skip to content

Commit

Permalink
Add tuple target fixture to DictComp fixture
Browse files Browse the repository at this point in the history
  • Loading branch information
@cnpryer
cnpryer committed Jul 17, 2023
1 parent 0e9a156 commit 3bc182b
Show file tree
Hide file tree
Showing 2 changed files with 146 additions and 1 deletion.
32 changes: 32 additions & 0 deletions crates/ruff_python_formatter/resources/test/fixtures/ruff/expression/dict_comp.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,35 @@
if
gggggggggggggggggggggggggggggggggggggggggggg
}

# Useful for tuple target (see https://github.com/astral-sh/ruff/issues/5779#issuecomment-1637614763)
{k: v for a, a, a, a, a, a, a, a, a, a, [a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a] in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension}
{k: v for a, a, a, a, a, a, a, a, a, a, (a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension}

# Leading
{ # Leading
k: v # Trailing
for a, a, a, a, a, a, a, a, a, a, ( # Trailing
a,
a,
a,
a,
a,
a,
a,
a,
a, # Trailing
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a, # Trailing
) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension # Trailing
} # Trailing
# Trailing
115 changes: 114 additions & 1 deletion crates/ruff_python_formatter/tests/snapshots/format@expression__dict_comp.py.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,38 @@ input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/expression
if
gggggggggggggggggggggggggggggggggggggggggggg
}
```
# Useful for tuple target (see https://github.com/astral-sh/ruff/issues/5779#issuecomment-1637614763)
{k: v for a, a, a, a, a, a, a, a, a, a, [a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a] in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension}
{k: v for a, a, a, a, a, a, a, a, a, a, (a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a,) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension}
# Leading
{ # Leading
k: v # Trailing
for a, a, a, a, a, a, a, a, a, a, ( # Trailing
a,
a,
a,
a,
a,
a,
a,
a,
a, # Trailing
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a, # Trailing
) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension # Trailing
} # Trailing
# Trailing```

## Output
```py
Expand Down Expand Up @@ -104,6 +135,88 @@ input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/expression
< hhhhhhhhhhhhhhhhhhhhhhhhhh
if gggggggggggggggggggggggggggggggggggggggggggg
}
# Useful for tuple target (see https://github.com/astral-sh/ruff/issues/5779#issuecomment-1637614763)
{
k: v
for a, a, a, a, a, a, a, a, a, a, [
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
] in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension
}
{
k: v
for a, a, a, a, a, a, a, a, a, a, (
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension
}
# Leading
{
# Leading
k: v # Trailing
for a, a, a, a, a, a, a, a, a, a, (
# Trailing
a,
a,
a,
a,
a,
a,
a,
a,
a, # Trailing
a,
a,
a,
a,
a,
a,
a,
a,
a,
a,
a, # Trailing
) in this_is_a_very_long_variable_which_will_cause_a_trailing_comma_which_breaks_the_comprehension # Trailing
} # Trailing
# Trailing
```
Expand Down

0 comments on commit 3bc182b

Please sign in to comment.