review comments

astral-sh · Sep 19, 2024 · 65732ee · 65732ee
1 parent b695a59
commit 65732ee
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/crates/red_knot_python_semantic/src/types/builder.rs b/crates/red_knot_python_semantic/src/types/builder.rs
@@ -52,21 +52,18 @@ impl<'db> UnionBuilder<'db> {
             }
             Type::Never => {}
             _ => {
-                let mut add = true;
                 let mut remove = vec![];
                 for element in &self.elements {
                     if ty.is_subtype_of(self.db, *element) {
-                        add = false;
+                        return self;
                     } else if element.is_subtype_of(self.db, ty) {
                         remove.push(*element);
                     }
                 }
                 for element in remove {
                     self.elements.remove(&element);
                 }
-                if add {
-                    self.elements.insert(ty);
-                }
+                self.elements.insert(ty);
             }
         }