Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule FLY002 cause autofix error #7197

Closed
qarmin opened this issue Sep 6, 2023 · 0 comments · Fixed by #7222
Closed

Rule FLY002 cause autofix error #7197

qarmin opened this issue Sep 6, 2023 · 0 comments · Fixed by #7222
Assignees
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 6, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select FLY002 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

def creae_file_publc_url(url, filename):
    return''.join([url, flename])

error

/home/rafal/test/tmp_folder/882_IDX_0_RAND_114325313818141405238226.py:2:11: FLY002 Consider `f'{url}{flename}'` instead of string join
Found 1 error.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/882_IDX_0_RAND_114325313818141405238226.py`, the rule codes FLY002, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

python_compressed.zip

@charliermarsh charliermarsh added bug Something isn't working fuzzer Surfaced via fuzzing. labels Sep 7, 2023
@charliermarsh charliermarsh self-assigned this Sep 7, 2023
charliermarsh added a commit that referenced this issue Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants