Fix ecosystem check for indico #10164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
fix-ecosystem-check
branch
from
46d7bd6
to
2efd128
Compare
MichaReiser
force-pushed
the
fix-ecosystem-check
branch
2 times, most recently
from
8a14243
to
78ff9f0
Compare
MichaReiser
commented
Feb 29, 2024
| # Remove once indico removed S401 from their ignore configuration | ||
| config_overrides={ | ||
| "lint.ignore": [ | ||
| "E226", # allow omitting whitespace around arithmetic operators |
There was a problem hiding this comment.
This is a bit silly but I couldn't find a way to remove a single rule from ignore
|
MichaReiser
force-pushed
the
fix-ecosystem-check
branch
from
78ff9f0
to
5cac02a
Compare
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
S410rule from the indico ecosystem check