Update E999 to show all syntax errors
#11900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/syntax-error-1
branch
from
96968ba
to
4dd412e
Compare
dhruvmanila
changed the title
E999 to show all syntax errors
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E999 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 49 projects unchanged)
demisto/content (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ Packs/ThreatQ/Integrations/ThreatQ/ThreatQ.py:325:8: E999 SyntaxError: Multiple exception types must be parenthesized
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E999 | 1 | 1 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
MichaReiser
approved these changes
Jun 18, 2024
| pycodestyle::rules::syntax_error(&mut diagnostics, parse_error, locator); | ||
| for parse_error in parse_errors { | ||
| pycodestyle::rules::syntax_error(&mut diagnostics, parse_error, locator); | ||
| } | ||
| // TODO(dhruvmanila): Remove this clone |
dhruvmanila
force-pushed
the
dhruv/syntax-error-1
branch
from
4dd412e
to
7b7e6b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the linter to show all the parse errors as diagnostics instead of just the first one.
Note that this doesn't affect the parse error displayed as error log message. This will be removed in a follow-up PR.
Breaking?
I don't think this is a breaking change even though this might give more diagnostics. The main reason is that this shouldn't affect any users because it'll only give additional diagnostics in the case of multiple syntax errors.
Test Plan
Add an integration test case which would raise more than one parse error.