Don't enforce returns and yields in abstract methods #12771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/abs
branch
from
f026e05
to
98d4ce7
Compare
charliermarsh
added
bug
charliermarsh
commented
Aug 9, 2024
crates/ruff_linter/src/rules/pydoclint/rules/check_docstring.rs
Outdated
Show resolved
Hide resolved
|
MichaReiser
approved these changes
Aug 9, 2024
charliermarsh
force-pushed
the
charlie/abs
branch
from
98d4ce7
to
30f72b6
Compare
AlexWaygood
reviewed
Aug 9, 2024
| @@ -25,6 +25,8 @@ use crate::rules::pydocstyle::settings::Convention; | |||
| /// Docstrings missing return sections are a sign of incomplete documentation | |||
| /// or refactors. | |||
| /// | |||
| /// This rule is not enforced for abstract methods and stubs functions. | |||
There was a problem hiding this comment.
Suggested change
| /// This rule is not enforced for abstract methods and stubs functions. | |
| /// This rule is not enforced for stub functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12685.