Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] - fix incorrect starred expression replacement for nested-min-max (PLW3301) #13089

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[pylint] - fix incorrect starred expression replacement for nested-min-max (PLW3301) #13089

merged 2 commits into from
Aug 26, 2024

Conversation

diceroll123
Copy link
Contributor

Summary

Moves the min/max detection up, and fixes #13088

Test Plan

cargo test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 25, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dhruvmanila
dhruvmanila approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhruvmanila dhruvmanila added the bug Something isn't working label Aug 26, 2024
@dhruvmanila dhruvmanila merged commit 5af4833 into astral-sh:main Aug 26, 2024
20 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@diceroll123 @dhruvmanila