Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Remove check for dot in alias name in useless-import-alias (PLC0414) #14345

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[pylint] Remove check for dot in alias name in useless-import-alias (PLC0414) #14345

merged 1 commit into from
Nov 14, 2024

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Nov 14, 2024

Follow-up to #14287 : when checking that name is the same as as_name in import name as as_name, we do not need to first do an early return if '.' is found in name.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dylwil3 dylwil3 merged commit ba6c7f6 into astral-sh:main Nov 14, 2024
20 checks passed
@dylwil3 dylwil3 deleted the isort-followup branch November 14, 2024 22:26
@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylwil3 @dhruvmanila