Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Pylint's cyclic-import rule (PLR0401) #3880

Closed
wants to merge 85 commits into from
Closed

Implement Pylint's cyclic-import rule (PLR0401) #3880

wants to merge 85 commits into from

Commits on Feb 26, 2023

  1. WIP

    @chanman3388
    chanman3388 committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    19b7755 View commit details
    Browse the repository at this point in the history

  2. return the list of imports per module

    Chris Chan committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    87fac94 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. first go at propagating imports out to where diagnostic results are c… 

    …ollected
    Chris Chan committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    e76cbd9 View commit details
    Browse the repository at this point in the history

  2. remove some unecessary clones

    Chris Chan committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    19b9d9c View commit details
    Browse the repository at this point in the history

  3. some comments

    @chanman3388
    chanman3388 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    4ec1f54 View commit details
    Browse the repository at this point in the history

  4. pull from main and refactor slightly

    @chanman3388
    chanman3388 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    fd65a38 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. remove some lifetime annotations

    Chris Chan committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c2181ca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'report_imports' of github.com:chanman3388/ruff into rep… 

    …ort_imports
    Chris Chan committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    f4acf2b View commit details
    Browse the repository at this point in the history

  3. fix tests and remove some print statements

    Chris Chan committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    2344bd8 View commit details
    Browse the repository at this point in the history

  4. rename LoggingLevel::from_str to from_python_logger_method_str

    Chris Chan committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    d2bbb41 View commit details
    Browse the repository at this point in the history

  5. fix lib_wasm

    Chris Chan committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    6809a03 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. fix conflicts after merging main

    @chanman3388
    chanman3388 committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    c7310cd View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. fix conflicts

    Chris Chan committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    2bd8b67 View commit details
    Browse the repository at this point in the history

  2. associate path with module imports

    Chris Chan committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    bac9fcd View commit details
    Browse the repository at this point in the history

  3. add new type to avoid clippy message about complex type

    Chris Chan committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    c02cc50 View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    Chris Chan committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    1a2caf0 View commit details
    Browse the repository at this point in the history

  5. use new type to avoid complex type message

    Chris Chan committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    9fb6c52 View commit details
    Browse the repository at this point in the history

  6. realise that actually we don't want a vec of hashmaps, but just one h… 

    …ashmap of imports
    Chris Chan committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    b67889e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch 'main' into report_imports

    @chanman3388
    chanman3388 authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5652512 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'main' into report_imports

    Chris Chan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2dd5feb View commit details
    Browse the repository at this point in the history

  2. the easy comments

    Chris Chan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2c41cee View commit details
    Browse the repository at this point in the history

  3. clippy and fmt changes

    Chris Chan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    99650fb View commit details
    Browse the repository at this point in the history

  4. implement struct

    Chris Chan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ce24b4f View commit details
    Browse the repository at this point in the history

  5. Add comment explaining macro usage and correct import

    Chris Chan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ad87a74 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Make DiagnosticsAndImports private as it doesn't need to be public

    @chanman3388
    chanman3388 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    80c7fad View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. resolve conflicts after merging main

    Chris Chan committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    a114fa9 View commit details
    Browse the repository at this point in the history

  2. remove an erroneously included comment

    Chris Chan committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    e00142d View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. add resolving of relative imports

    @chanman3388
    chanman3388 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    57ea484 View commit details
    Browse the repository at this point in the history

  2. fix case where package is None

    @chanman3388
    chanman3388 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    a255d58 View commit details
    Browse the repository at this point in the history

  3. fix case where level of a relative import is 0

    @chanman3388
    chanman3388 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    1d7dc5d View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. fix conflicts

    @chanman3388
    chanman3388 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1645877 View commit details
    Browse the repository at this point in the history

  2. clippy

    @chanman3388
    chanman3388 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8194782 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @chanman3388
    chanman3388 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d20bb3d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Merge branch 'report_imports' of github.com:chanman3388/ruff into rep… 

    …ort_imports
    @chanman3388
    chanman3388 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f644cd3 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. merge in branch PLR0401

    @chanman3388
    chanman3388 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8c321b7 View commit details
    Browse the repository at this point in the history

  2. add PLR0401 to ruff.schema.json

    @chanman3388
    chanman3388 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    45c7e12 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into report_imports

    @chanman3388
    chanman3388 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    7aa5db8 View commit details
    Browse the repository at this point in the history

  4. use Box to avoid clippy::result-large-err

    @chanman3388
    chanman3388 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4a2e607 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Actually detect all the cycles. Use a slightly hacky way to avoid dup… 

    …licate cycles.
    @chanman3388
    chanman3388 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    b2b8d9f View commit details
    Browse the repository at this point in the history

  2. Only detect cycles for a given file

    @chanman3388
    chanman3388 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    216e736 View commit details
    Browse the repository at this point in the history

  3. fix import from resolution in imports.rs

    @chanman3388
    chanman3388 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    baf2666 View commit details
    Browse the repository at this point in the history

  4. remove redundant method on Imports, tidy up checkers/imports.rs

    @chanman3388
    chanman3388 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    16b0fbb View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. Merge branch 'main' into report_imports

    @chanman3388
    chanman3388 committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    e927718 View commit details
    Browse the repository at this point in the history

  2. separate reporting of imports from cyclic import detection

    @chanman3388
    chanman3388 committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    47cdc75 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. remove cyclic imports

    @chanman3388
    chanman3388 committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    382ad1f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. add mapping of module to path and path to module

    @chanman3388
    chanman3388 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    1bd96f2 View commit details
    Browse the repository at this point in the history

  2. Once a node is fully visited in the dependency graph we don't start d… 

    …etecting cycles from it again
    @chanman3388
    chanman3388 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    21dd78f View commit details
    Browse the repository at this point in the history

  3. first working version of cyclic imports rule

    @chanman3388
    chanman3388 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5579255 View commit details
    Browse the repository at this point in the history

  4. remove redudant module mappings

    @chanman3388
    chanman3388 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c01897c View commit details
    Browse the repository at this point in the history

  5. merge main

    @chanman3388
    chanman3388 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    7d1683c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Remove some more bugs and use hashsets for the cycles

    chanman3388 committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    f05594b View commit details
    Browse the repository at this point in the history

  2. fix duplicate cycles

    chanman3388 committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    631bbab View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Merge branch 'report_imports' into PLR0401

    @chanman3388
    chanman3388 authored Apr 1, 2023
    Configuration menu
    Copy the full SHA
    9d0a9b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Merge branch 'main' into PLR0401

    chanman3388 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3f3e04e View commit details
    Browse the repository at this point in the history

  2. resolve conflicts

    chanman3388 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2bf41fa View commit details
    Browse the repository at this point in the history

  3. merge in main

    chanman3388 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5ea1d8d View commit details
    Browse the repository at this point in the history

  4. small tweaks

    chanman3388 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    864c89a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. use Arc<str> to avoid string cloning

    chanman3388 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    57418ae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into PLR0401

    @chanman3388
    chanman3388 authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    cf53763 View commit details
    Browse the repository at this point in the history

  3. Fix bug when package is None supplied to cyclic_import

    @chanman3388
    chanman3388 authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    992e151 View commit details
    Browse the repository at this point in the history

  4. clippy/fmt

    chanman3388 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a098167 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. merge in main

    @chanman3388
    chanman3388 committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    ba3f8bc View commit details
    Browse the repository at this point in the history

  2. make work with new function signature

    @chanman3388
    chanman3388 committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    990a815 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. add some more unittests

    @chanman3388
    chanman3388 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ac32674 View commit details
    Browse the repository at this point in the history

  2. lint + fmt

    @chanman3388
    chanman3388 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4448608 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. add more unittests, fix bug on importing self

    @chanman3388
    chanman3388 committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    e6bcf1f View commit details
    Browse the repository at this point in the history

  2. revert to version from main

    @chanman3388
    chanman3388 committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    b3bd027 View commit details
    Browse the repository at this point in the history

  3. change some unittest names

    @chanman3388
    chanman3388 committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    c878a78 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. address some of the quicker review comments

    @chanman3388
    chanman3388 committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    27ce49c View commit details
    Browse the repository at this point in the history

  2. use ids to represent imports when detecting cycles instead

    @chanman3388
    chanman3388 committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    079cb0c View commit details
    Browse the repository at this point in the history

  3. linting

    @chanman3388
    chanman3388 committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    be5bb5d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. amend comment and fix typo

    @chanman3388
    chanman3388 committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    ed347e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. use vec instead of FxHashMap for id_to_module

    @chanman3388
    chanman3388 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    f819262 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. use &str instead of Arc<str>

    @chanman3388
    chanman3388 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7a7a1a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. merge main

    @chanman3388
    chanman3388 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    a621483 View commit details
    Browse the repository at this point in the history

  2. merge main

    @chanman3388
    chanman3388 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bf35ae3 View commit details
    Browse the repository at this point in the history

  3. merge main

    @chanman3388
    chanman3388 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    41efef3 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. comment out debug! calls

    @chanman3388
    chanman3388 committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    fdd5fd2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. merge main

    @chanman3388
    chanman3388 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9cfb746 View commit details
    Browse the repository at this point in the history

  2. fix after merging

    @chanman3388
    chanman3388 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    456f43b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. merge main

    @chanman3388
    chanman3388 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    8ba0b63 View commit details
    Browse the repository at this point in the history

  2. fix

    @chanman3388
    chanman3388 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    e0110e2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into PLR0401

    @chanman3388
    chanman3388 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    bbc5c23 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge branch 'main' into PLR0401

    @chanman3388
    chanman3388 authored May 18, 2023
    Configuration menu
    Copy the full SHA
    597ebba View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. merge main

    @chanman3388
    chanman3388 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6695702 View commit details
    Browse the repository at this point in the history