Add basic support for PEP 695 #5842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jul 17, 2023
zanieb
commented
Jul 17, 2023
| self.unparse_expr(name, precedence::MAX); | ||
| for type_param in type_params { | ||
| self.unparse_type_param(type_param); | ||
| self.p(", ") |
There was a problem hiding this comment.
Need to get a little more sophisticated in handling trailing comma, I presume.
There was a problem hiding this comment.
Check out the self.p_delim(&mut first, ", "); line in the Stmt::With case.
zanieb
commented
Jul 17, 2023
| bound.as_ref().map_or(false, |value| any_over_expr(value, func)) | ||
| } | ||
| TypeParam::TypeVarTuple(ast::TypeParamTypeVarTuple { .. }) => { | ||
| false |
There was a problem hiding this comment.
Should any_over_expr visit names?
There was a problem hiding this comment.
It should visit all expressions, so needs to recurse on anything that might contain an expression.
There was a problem hiding this comment.
The names can't contain expressions, they're just containers for a string. It seems like a pain if you were trying to visit parameter names here but I guess we can tackle that with another helper (or as it comes up).
PR Check ResultsBenchmarkLinuxWindows |
|
Superseded by #5459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5062
Summary
Adds basic boilerplate support for PEP 695 without the expectation that we will actually do anything with the contents of such expressions.
Bumps our RustPython/Parser fork to get support for PEP 695 as tracked by RustPython/Parser#82
Test Plan