Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting of type alias statements #6162

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 28, 2023

Part of #5062
Extends #6161
Closes #5929

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

PR Check Results

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.02      8.5±0.06ms     4.8 MB/sec    1.00      8.3±0.10ms     4.9 MB/sec
formatter/numpy/ctypeslib.py               1.00  1644.0±24.84µs    10.1 MB/sec    1.00  1642.3±24.25µs    10.1 MB/sec
formatter/numpy/globals.py                 1.00    183.0±4.08µs    16.1 MB/sec    1.00    182.3±3.57µs    16.2 MB/sec
formatter/pydantic/types.py                1.00      3.6±0.09ms     7.1 MB/sec    1.00      3.6±0.10ms     7.2 MB/sec
linter/all-rules/large/dataset.py          1.00     11.0±0.08ms     3.7 MB/sec    1.03     11.3±0.12ms     3.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.8±0.02ms     5.9 MB/sec    1.00      2.8±0.02ms     5.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    379.8±1.21µs     7.8 MB/sec    1.00    378.4±0.96µs     7.8 MB/sec
linter/all-rules/pydantic/types.py         1.01      5.0±0.06ms     5.1 MB/sec    1.00      4.9±0.07ms     5.2 MB/sec
linter/default-rules/large/dataset.py      1.02      5.9±0.03ms     6.9 MB/sec    1.00      5.7±0.04ms     7.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01   1198.0±3.18µs    13.9 MB/sec    1.00   1192.0±2.07µs    14.0 MB/sec
linter/default-rules/numpy/globals.py      1.00    132.5±0.46µs    22.3 MB/sec    1.00    132.2±0.28µs    22.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.5±0.03ms    10.1 MB/sec    1.00      2.5±0.04ms    10.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     10.1±0.11ms     4.0 MB/sec    1.00     10.0±0.11ms     4.1 MB/sec
formatter/numpy/ctypeslib.py               1.00  1955.7±24.20µs     8.5 MB/sec    1.00  1953.0±41.65µs     8.5 MB/sec
formatter/numpy/globals.py                 1.00    214.6±3.88µs    13.7 MB/sec    1.01    216.4±6.94µs    13.6 MB/sec
formatter/pydantic/types.py                1.01      4.3±0.05ms     6.0 MB/sec    1.00      4.2±0.07ms     6.0 MB/sec
linter/all-rules/large/dataset.py          1.01     13.6±0.13ms     3.0 MB/sec    1.00     13.5±0.12ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      3.6±0.04ms     4.7 MB/sec    1.00      3.5±0.03ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    430.8±5.77µs     6.8 MB/sec    1.01    433.5±6.35µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.0±0.09ms     4.2 MB/sec    1.01      6.1±0.09ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      7.3±0.06ms     5.6 MB/sec    1.00      7.3±0.04ms     5.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1473.5±18.51µs    11.3 MB/sec    1.00  1477.1±13.82µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    165.2±3.07µs    17.9 MB/sec    1.00    165.4±4.07µs    17.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.04ms     8.0 MB/sec    1.01      3.2±0.04ms     8.0 MB/sec

@zanieb zanieb force-pushed the zanie/695-format-type-alias branch from 75ae8dc to f85f8e3 Compare July 28, 2023 22:11
@konstin konstin mentioned this pull request Jul 31, 2023
72 tasks
@konstin konstin added the formatter Related to the formatter label Jul 31, 2023
@zanieb zanieb mentioned this pull request Jul 31, 2023
@MichaReiser MichaReiser linked an issue Jul 31, 2023 that may be closed by this pull request
@zanieb zanieb force-pushed the zanie/695-format branch 5 times, most recently from 655d055 to 4ac79ac Compare August 2, 2023 16:07
@zanieb zanieb force-pushed the zanie/695-format-type-alias branch from f85f8e3 to cbdafd9 Compare August 2, 2023 16:11
@zanieb zanieb marked this pull request as ready for review August 2, 2023 20:22
@zanieb
Copy link
Member Author

zanieb commented Aug 2, 2023

Will rebase on merge of #6161

Base automatically changed from zanie/695-format to main August 2, 2023 20:29
@zanieb zanieb force-pushed the zanie/695-format-type-alias branch from 9f36d45 to 4652552 Compare August 2, 2023 20:30
@zanieb zanieb enabled auto-merge (squash) August 2, 2023 20:36
@zanieb zanieb merged commit 5b2e973 into main Aug 2, 2023
16 checks passed
@zanieb zanieb deleted the zanie/695-format-type-alias branch August 2, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter: TypeAlias
3 participants