Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI to respect fix applicability #7769

Merged
merged 29 commits into from
Oct 6, 2023
Merged

Update CLI to respect fix applicability #7769

merged 29 commits into from
Oct 6, 2023

Commits on Oct 3, 2023

  1. Update CLI to respect fix applicability

    @evanrittenhouse @zanieb
    evanrittenhouse authored and zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d01969c View commit details
    Browse the repository at this point in the history

  2. Fixups for CI

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    74acdf5 View commit details
    Browse the repository at this point in the history

  3. Update CLI documentation for fixes

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    85b5efe View commit details
    Browse the repository at this point in the history

  4. Use self.flags.intersects consistently

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    7c05fb5 View commit details
    Browse the repository at this point in the history

  5. Revert change to notebook cell iteration

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    87def58 View commit details
    Browse the repository at this point in the history

  6. Remove stale todo from test

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6577833 View commit details
    Browse the repository at this point in the history

  7. Cleanup internal commentary on the fix rules

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d004ddc View commit details
    Browse the repository at this point in the history

  8. Refactor fix_file implementation to use Fix.applies 

    #5119 (comment)
    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    96b8ce1 View commit details
    Browse the repository at this point in the history

  9. Use different symbols for fix messages depending on applicability 

    Refactors `violation_string` as well
    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    9949fa0 View commit details
    Browse the repository at this point in the history

  10. Update snapshots to reflect changes in fix messages

    @zanieb
    zanieb committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    ee903bf View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Remove comment detailing ordering

    @zanieb
    zanieb committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b24d9dd View commit details
    Browse the repository at this point in the history

  2. Refactor RuleCodeAndBody.fmt to avoid using unwrap

    @zanieb
    zanieb committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a5ef7d6 View commit details
    Browse the repository at this point in the history

  3. Do not display fixes with manual applicability

    @zanieb
    zanieb committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    cb6c25e View commit details
    Browse the repository at this point in the history

  4. Rename --suggested-fix to --unsafe-fixes and fix interaction with… 

    … `--fix`
    @zanieb
    zanieb committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8683340 View commit details
    Browse the repository at this point in the history

  5. Improve messaging around unsafe fixes

    @zanieb
    zanieb committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d3f0558 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Refactor UnsafeFixes out of FixMode

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d35d68d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into zanie/applicability

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    953ee4a View commit details
    Browse the repository at this point in the history

  3. Update order of applicability levels for Ord

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    98c2c29 View commit details
    Browse the repository at this point in the history

  4. Fix merge compile errors

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f57b853 View commit details
    Browse the repository at this point in the history

  5. Refactor unsafe fix display to avoid using flags

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a57e3d3 View commit details
    Browse the repository at this point in the history

  6. Fix unsafe fixes in grouped emitter

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d3cb905 View commit details
    Browse the repository at this point in the history

  7. Refactor FixableStatistics

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2a5f454 View commit details
    Browse the repository at this point in the history

  8. Lint

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8d89499 View commit details
    Browse the repository at this point in the history

  9. Fixup CheckCommand

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b72ab24 View commit details
    Browse the repository at this point in the history

  10. FixableStatistics -> FixableSummary

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    356f409 View commit details
    Browse the repository at this point in the history

  11. Wrap --fix and --unsafe-fixes in code quotes

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1bbc858 View commit details
    Browse the repository at this point in the history

  12. Clean up integration tests

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b6e3a9a View commit details
    Browse the repository at this point in the history

  13. Commit missing snapshot

    @zanieb
    zanieb committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    47b146b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Avoid reading unsafe_fixes from nested configuration files

    @zanieb
    zanieb committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    859ac7d View commit details
    Browse the repository at this point in the history