Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Never to NoReturn in auto-typing in Python >= 3.11 #9213

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Prefer Never to NoReturn in auto-typing in Python >= 3.11 #9213

merged 1 commit into from
Dec 20, 2023

Conversation

charliermarsh
Copy link
Member

Closes #9212.

@charliermarsh charliermarsh changed the title Prefer Never to NoReturn in auto-typing Prefer Never to NoReturn in auto-typing Dec 20, 2023
@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Dec 20, 2023
@charliermarsh charliermarsh merged commit 29846f5 into main Dec 20, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/never branch December 20, 2023 14:36
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb
Copy link
Member

zanieb commented Dec 20, 2023

@charliermarsh some context please :)

@charliermarsh
Copy link
Member Author

python/typing#1458 (comment)

@zanieb zanieb changed the title Prefer Never to NoReturn in auto-typing Prefer Never to NoReturn in auto-typing in Python >= 3.11 Dec 21, 2023
@miccal miccal mentioned this pull request Dec 22, 2023
Merged
@tooruu tooruu mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer Never to NoReturn in fixes
2 participants
@charliermarsh @zanieb