Bump boostrap ruff to 0.4.4 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last tests failure is insanely weird and I'm not sure if its expected . Ill leave it without change and let someone else have a look at it, because I cant reproduce it locally and I'm not sure what other file it could be talking about (does https://github.com/astral-sh/rye/actions/runs/9054124712/job/24873624010#step:7:206 |
|
Yes, space.init looks like it uses regular "rye init" which creates |
|
Thanks for the extra pair of eyes. I had a suspicion it had something to do with that, but was not 100% sure. Made the test account for that too |
charliermarsh
approved these changes
May 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed ruff was a bit old and was missing a lot of rules, leading to a lot of "unused noqa".
I unfortunately dont have the rust knowledge to improve this, but it would be nice if we could update ruff independently of rye and still run it using
rye lint/fmt.Thanks for this amazing tool! Gave it a shot today and really really enjoyed playing around with it and testing it out. Currently porting some of my projects to use it!